Giedrius Statkevičius
Giedrius Statkevičius
> @GiedriusS Can you help review this as well? > > I think one thing I am not sure is that how to make the hook easier to use if...
Got a hacked-together version working with the current code: https://github.com/thanos-io/thanos/pull/7109. This means that it should be enough to get this merged to unblock our project
Could anyone take a look? :disappointed:
I tried adding a length method here https://github.com/prometheus/prometheus/pull/13093, maybe worth revisiting?
Was head GC happening around that time? Do you see that in logs?
Another concern that I have seems to not be mentioned everywhere. What will happen to the v1.0 version? Will implementors be able to choose whichever version they prefer or only...
Thanos Query also deduplicates alerts so I think that's why you don't see them. Are they visible if you removed replica labels from Query?
> Really cool feature, it removes the need to manage configuration dynamically for a subset of use cases. > > I am wondering if we should go with regex directly...
We've migrated to v5 a long time ago: https://github.com/GiedriusS/TwitchNotifier/commit/6348165fcab7e90a31e496ab7073e48813c8405e. Could you see if it is still reproducible with the newest version?
Could we close this now, then?