Hendrik Brucker

Results 67 comments of Hendrik Brucker

Oh sorry, I overlooked that. But I think it's fine either way. Could you add a `Depends on ` to your PR description?

@akien-mga Yes indeed (child index, slot index and port index), but unfortunately that's just how the current system works. Changing this would basically require a complete rework of GraphNode/GraphEdit (much...

I think inactive properties should be colored gray, yellow clashes with properties of editable children (see https://github.com/godotengine/godot/pull/53260)

Rebased and addressed all review comments. @Yagich 1. Yes, it should. You can test it with the VS expression node which is resizable. 2. I assume you mean the connectable...

@Yagich Thanks for testing. I made both `attach_graph_element_to_frame()` and `detach_graph_element_from_frame()` more robust.

Rebased and adjusted the style a bit after #85017 has been merged. ![image](https://github.com/godotengine/godot/assets/50084500/10cdbd1e-ae05-49ee-bc14-114da430752e) ![image](https://github.com/godotengine/godot/assets/50084500/311d27c0-8a6d-4e53-b2bf-6d00fa59d546)

@akien-mga @BlueCube3310 Thanks for testing! All the described (technical) issues should be solved now. Regarding the usability problems: I will experiment a bit with a cursor hint (when dragging a...

Small update: - Removed the description feature - Refactoring on the visual shader side - Added a hint for empty frames: ![frame drop](https://github.com/godotengine/godot/assets/50084500/199dc126-69ec-4832-8393-e2089cac4767)

Ok, I might have fixed the crashes, but please recheck since I had a hard time reproducing. > Title editing popup awkwardly appears near the cursor and it's super small:...

Rebased and fixed a small resizing issue. Initially, I wanted to split keep autoshrink always enabled (and split the free resize functionality from this PR), but I think it works...