godot-benchmarks icon indicating copy to clipboard operation
godot-benchmarks copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Implement a benchmark algorithm `Delaunay3D`

Open Chubercik opened this issue 2 years ago • 6 comments

  • Implements 🟪Algorithm🟪 Delaunay3D: Delaunay 1000 points in 3D benchmark of the Math category proposed in #36.
  • Depends on https://github.com/godotengine/godot/pull/83353.

Chubercik avatar Oct 14 '23 22:10 Chubercik

If the PR mentioned above gets merged, completing this PR should be as easy as changing the insides of the benchmark_delaunay3D() function to:

Geometry3D.tetrahedralize_delaunay(scattered_points)

Chubercik avatar Oct 14 '23 23:10 Chubercik

Committed an update that should be the final version. I haven't changed the number of points, because on my low-end laptop this benchmark takes ~4000ms when running on a dev build of https://github.com/godotengine/godot/pull/83353/commits/bc78c832e98bb8e9b36a4d236d5ad9ce36de66c5.

I assume on a rig with the CPU you mentioned this will take significantly less time.

Chubercik avatar Oct 24 '23 09:10 Chubercik

@Chubercik Can you change this PR's status from draft to ready for review?

Geometror avatar Oct 31 '23 11:10 Geometror

The reason why I left it hanging as a draft is because until (probably) Godot 4.3 comes out, code from this PR won't be able to run - there is no such function as Geometry3D.tetrahedralize_delaunay() in 4.1, upcoming 4.2 or even master, yet.

Chubercik avatar Oct 31 '23 11:10 Chubercik

Oh sorry, I overlooked that. But I think it's fine either way. Could you add a Depends on <link to PR> to your PR description?

Geometror avatar Nov 06 '23 18:11 Geometror

Sure thing, the PR description has been updated.

Chubercik avatar Nov 06 '23 22:11 Chubercik