godot icon indicating copy to clipboard operation
godot copied to clipboard

Published 20 hours ago • verified publisher icon godotengine

Fix port cache calculation in GraphNode

Open nagidev opened this issue 10 months ago • 2 comments

Fixes #91082 by updating the left_port_cache & right_port_cache calculation in GraphNode::_port_pos_update.

nagidev avatar Apr 23 '24 22:04 nagidev

@Geometror See also #90229 and #90787. Seems like it's easy to make mistakes in this code with different indices.

akien-mga avatar Apr 24 '24 11:04 akien-mga

@akien-mga Yes indeed (child index, slot index and port index), but unfortunately that's just how the current system works. Changing this would basically require a complete rework of GraphNode/GraphEdit (much more sophisticated than the refactoring I've done). Maybe for 5.0 :)

Geometror avatar Apr 24 '24 18:04 Geometror

Thanks! And congrats for your first merged Godot contribution :tada:

akien-mga avatar Apr 25 '24 10:04 akien-mga