fa
fa copied to clipboard
FAForever
Re: Abstract and Optimize Reclaim Labels
Yeah, I had it working, but then something broke when I removed the debug code. Go figure.
That should mitigate the problem for now, though I think the color scaling I put in should be adjusted.
Nearly all of it is--the only thing I could have left out were some of the Layout helpers, but I already needed some of changes and the rest needed to be done as well. Not worth a separate PR. You might be looking at some of the changes that affect other files (the annotation stuff in particular can look unrelated), however, those are things that shouldn't be done separately. We have tried separating out aspects into different PR's in the past and it is nasty.
The performance degraded quite a bit, in comparison to what we have in deploy/fafdevelop, do you have an idea where the extra time is going towards to?
Yes, I made the mistake of optimizing before abstracting... it's finally working like I want it to, but I need to do another optimization pass. I suspect it's how I'm handling frame updates.
I've done a review and I'm not sure.
When moving the camera this solution lags more, causing it to dip down to 20 - 30 fps on my computer. Meanwhile the solution we have on deploy/fafdevelop remains at 60 fps or more. I like a lot of the work in this pull request, one of them being the smoother colors. But I'm not sure if the performance drop is acceptable, especially as I have a relatively fast computer.
Let us sit down together next week and discuss it over voice.
@Hdt80bro I'll close this pull request tomorrow. Time caught up and this pull request feels dated at this point