Adrián Chaves
Adrián Chaves
Does setting `SCHEDULER_PRIORITY_QUEUE` to `"scrapy.pqueues.DownloaderAwarePriorityQueue"` make any difference? If it does, maybe we can consider https://github.com/scrapy/scrapy/pull/6940 a fix for this.
That line in the `custom_settings` attribute of your spider (or `SCHEDULER_PRIORITY_QUEUE = "scrapy.pqueues.DownloaderAwarePriorityQueue"` in `settings.py`) is all.
I thought you might want to address https://github.com/scrapy/scrapy/pull/6966#discussion_r2228888971 first. Or do you prefer to keep the current link?
You must have accidentally reverted that change when you force-pushed some commits, because the current changes (see the Files tab) have the old link. (also, no need to force push,...
This is not really a bug, it is a expected behavior, given lists are mutable objects in Python. And the behavior you are complaining about may actually be desired in...
I believe the behavior is to be expected by anyone familiar with https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments That said, I don’t see an issue with warning about this in the function description.
Oh, right. Added.
I was thinking somewhere in [`scrapy.cmdline.execute()`](https://github.com/scrapy/scrapy/blob/ed63fa94d698ba09875d45c20253b98e05cca5e5/scrapy/cmdline.py#L169), so that add-on settings also load for other commands besides `scrapy settings`. Originally I thought about modifying [`get_project_settings()`](https://github.com/scrapy/scrapy/blob/master/scrapy/utils/project.py#L65), [called early there](https://github.com/scrapy/scrapy/blob/ed63fa94d698ba09875d45c20253b98e05cca5e5/scrapy/cmdline.py#L174), to either run...
[Could you edit the YAML file instead?](https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data)
> What do you guys think I should do? - Remove the env var condition unless it is necessary. - Define a new boolean Scrapy setting, False by default. -...