Adrián Chaves

Results 860 comments of Adrián Chaves

[At a glance](https://github.com/scrapy/scrapy/blob/67ab8d4650c1e9212c9508803c7b5265e166cbaa/scrapy/core/engine.py#L154-L159), it seems to me that indeed spider_closed and all handlers are resolved, and then `engine_stopped` and its handlers are resolved. Not sure if there are corner cases,...

Can anyone check that https://github.com/scrapinghub/dateparser/pull/1288 works for you?

Hey, @mkcor, do you think you could fix the Flake8-reported issue (`tests/test_spidermiddleware_offsite.py:45:5: E303 too many blank lines (2)`) or give the Scrapy team permission to edit your pull request? (4...

Closing in favor of https://github.com/zytedata/zyte-common-items/pull/124.

[It should be fixed in 1.1.2, released today](https://github.com/scrapinghub/dateparser/blob/master/HISTORY.rst#112-2022-10-20). Please, see if you can reproduce the issue with 1.1.2.

https://github.com/scrapinghub/dateparser/pull/1062#issuecomment-1293953513

Closing as per https://github.com/scrapy/scrapy/pull/6706#issuecomment-2715665194 (Great work, though!)

It works as expected if you indicate the input language: ```python >>> dateparser.parse("20 Mart 2001", languages=["tr"]) datetime.datetime(2001, 3, 20, 0, 0) ``` If you know the input language, you should...

I am reopening in case we can be more smart about this specific scenario, but I consider this a minor issue.

Please, see https://dateparser.readthedocs.io/en/latest/contributing.html#guidelines-for-editing-translation-data