Florian Vahl comments

Results 184 comments of


                                            Florian Vahl

Jazzy migration

The second merge was weird but needed for some reason

Jazzy migration

Protobuf generates Python code. That Python code makes mypy unhappy. But we can not exclude it, because ros2 fucked up it's mypy configuration by adding another layer on top of...

Fix walking python bindings

@coderabbitai review

ros control should only publish joint states after the wait time is elapsed

Ideally we should wait with everything. I am not 100% sure how I would implement this feature. I think it should be a few more lines tho .

ros control should only publish joint states after the wait time is elapsed

Not really

parameter for testing goalie behavior with only one robot

What behavior makes sense in this regard? I think testing with the team comm simulator makes more sense in this case.

Kick foot decision biased goal position while going to ball

We did some testing during the Go, which still had some issues iirc.. Maybe @cleWu03 remembers more or we can test it in sim.

Kick foot decision biased goal position while going to ball

I think there are some issues with it not being stable on the real robot

[Bug] (and solution?) PPO policy training and saving fails in latest Brax version

I also have this issue

tf2_ros_py: Add timeouts to async buffer interfaces

What is holding this PR back at the moment? :) @clalancette