Exempt-Medic

Results 89 comments of Exempt-Medic

> I think this should be `not (0b111 & self.classification)` to leave the door open for filler_skip_balancing and to work with worlds that use their own custom flags So the...

> Marked for merge after hotfix window > > ~How am I actually going to remember which PRs I've "marked for merge"? I didn't think this through~ > Marked for...

https://discord.com/channels/731205301247803413/1214608557077700720/1295901455244591185 Oh, you fixed it already 🤦

You may want to update the early option docstrings, since the parenthetical doesn't exactly apply

I did not test webhost whatsoever

This has conflicts btw, also make sure you update https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/CODEOWNERS as well

> > This has conflicts btw > > Should I leave the README alone and let someone else add the game to the supported list after its merged? Updating it...

Two things I think you may want to consider adding: 1. `get_filler_item_name` This makes it so that when a filler item is required from your world (like with itemlinks, plando,...

Another thing I don't know if you'd considered, but you could add location and item groups, things like "Act 2" locations and "Card" items and other things like that