Exempt-Medic

Results 89 comments of Exempt-Medic

@digiholic Reminder that this exists

Why does this PR include https://github.com/ArchipelagoMW/Archipelago/pull/3936 ?

> Could you elaborate on what Stardew does / needs to do? There's at least https://github.com/ArchipelagoMW/Archipelago/blob/ba8f03516e4d5453d9c148f89f0215611a4ef0db/worlds/stardew_valley/requirements.txt#L1 https://github.com/ArchipelagoMW/Archipelago/blob/ba8f03516e4d5453d9c148f89f0215611a4ef0db/worlds/stardew_valley/requirements.txt#L2 Also maybe these: https://github.com/ArchipelagoMW/Archipelago/blob/ba8f03516e4d5453d9c148f89f0215611a4ef0db/worlds/stardew_valley/test/stability/TestStability.py#L15 https://github.com/ArchipelagoMW/Archipelago/blob/ba8f03516e4d5453d9c148f89f0215611a4ef0db/worlds/stardew_valley/data/game_item.py#L43

Since you're updating these, you should also update the triggers guide to include examples of all of these new functions

This has conflicts and I'm not sure if it should be open still?

> Pre-filling `junkItemsNames` looks good to me but why is ItemType.HeartPiece, ItemType.ArrowUpgrade5 and ItemType.BombUpgrade5 missing? Can they cause problems if you have too many? If they can't though then it...

It seems like this removes the ability to have plando blocks without any locations listed. For example, so that specific items end up in specific worlds. Is the intended workaround...

Just putting this comment here as well, I feel the proper fix for Blasphemous is to remove pre_fill entirely and have these option-based item placements happen before plando. Such as...

I believe the Blasphemous changes can now be removed