Archipelago icon indicating copy to clipboard operation
Archipelago copied to clipboard

Inscryption: Implement new game

Open DrBibop opened this issue 1 year ago • 1 comments

What is this fixing or adding?

Adds new world for the game Inscryption. https://store.steampowered.com/app/1092790/Inscryption/

Learn more about the implementation here: https://github.com/Glowbuzz/Archipelago/blob/Inscryption/worlds/inscryption/docs/en_Inscryption.md

How was this tested?

Has been available publicly and regularly tested by the community and the world developers since september of 2023 through our future-game-design thread. It has been included in multiple community asyncs as a stable unsupported game. Unit tests have also been added for logic.

DrBibop avatar Jul 05 '24 07:07 DrBibop

Some of the latest changes do still need some testing but I'm starting the PR anyway in case anything needs changing

DrBibop avatar Jul 05 '24 07:07 DrBibop

This has conflicts btw, also make sure you update https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/CODEOWNERS as well

Exempt-Medic avatar Aug 26 '24 22:08 Exempt-Medic

This has conflicts btw

Should I leave the README alone and let someone else add the game to the supported list after its merged?

DrBibop avatar Aug 26 '24 23:08 DrBibop

This has conflicts btw

Should I leave the README alone and let someone else add the game to the supported list after its merged?

Updating it yourself is best

Exempt-Medic avatar Aug 26 '24 23:08 Exempt-Medic

Okay, resolved the conflict

DrBibop avatar Aug 26 '24 23:08 DrBibop

Two things I think you may want to consider adding:

  1. get_filler_item_name This makes it so that when a filler item is required from your world (like with itemlinks, plando, or a few other things) it will only pull the items you want it to instead of any random item, including progression items.
  2. start_inventory_from_pool This is an opt-in option, but it's very easy to setup ( for an example: https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/tunic/options.py#L194 ). This would allow players to have a start_inventory option that actually removes items from the pool instead of just adding duplicates (this would also benefit from get_filler_item_name since it uses that). For another simple example from TUNIC: https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/tunic/init.py#L320

Exempt-Medic avatar Aug 27 '24 00:08 Exempt-Medic

Another thing I don't know if you'd considered, but you could add location and item groups, things like "Act 2" locations and "Card" items and other things like that

Exempt-Medic avatar Aug 29 '24 13:08 Exempt-Medic

If everything looks okay, I'm planning on doing another beta release with the recent changes and undraft this PR after

DrBibop avatar Sep 04 '24 00:09 DrBibop