Archipelago
Archipelago copied to clipboard
Inscryption: Implement new game
What is this fixing or adding?
Adds new world for the game Inscryption. https://store.steampowered.com/app/1092790/Inscryption/
Learn more about the implementation here: https://github.com/Glowbuzz/Archipelago/blob/Inscryption/worlds/inscryption/docs/en_Inscryption.md
How was this tested?
Has been available publicly and regularly tested by the community and the world developers since september of 2023 through our future-game-design thread. It has been included in multiple community asyncs as a stable unsupported game. Unit tests have also been added for logic.
Some of the latest changes do still need some testing but I'm starting the PR anyway in case anything needs changing
This has conflicts btw, also make sure you update https://github.com/ArchipelagoMW/Archipelago/blob/main/docs/CODEOWNERS as well
This has conflicts btw
Should I leave the README alone and let someone else add the game to the supported list after its merged?
This has conflicts btw
Should I leave the README alone and let someone else add the game to the supported list after its merged?
Updating it yourself is best
Okay, resolved the conflict
Two things I think you may want to consider adding:
get_filler_item_nameThis makes it so that when a filler item is required from your world (like with itemlinks, plando, or a few other things) it will only pull the items you want it to instead of any random item, including progression items.start_inventory_from_poolThis is an opt-in option, but it's very easy to setup ( for an example: https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/tunic/options.py#L194 ). This would allow players to have astart_inventoryoption that actually removes items from the pool instead of just adding duplicates (this would also benefit fromget_filler_item_namesince it uses that). For another simple example from TUNIC: https://github.com/ArchipelagoMW/Archipelago/blob/main/worlds/tunic/init.py#L320
Another thing I don't know if you'd considered, but you could add location and item groups, things like "Act 2" locations and "Card" items and other things like that
If everything looks okay, I'm planning on doing another beta release with the recent changes and undraft this PR after