Manuel Spigolon

Results 381 comments of Manuel Spigolon

Closing as not strictly needed

I checked the v4 and it has the same issue, but I think the doc is correct and the behaviour is wrong > I checked the relevant logic and it...

Should this PR being regenerated?

closing in favour of: https://github.com/fastify/otel/issues/110

The coverage seems not fine If we compare this PR with this other one: - https://github.com/fastify/fastify/pull/6247 This one seems a sligtly better because it adds a single try/catch execution compared...

This code: https://github.com/fastify/fastify/pull/6229/files#diff-15a9e086692377c86b02752c54c928f4ca6f697758fc5dacc09bbde1d2dff96bR75-R76 is never reached due the new try/catch, so we need to remove it to restore the coverage

What if those deps save us from some injection? I say that because I trust the `glob`'s maintainer and his work. In this scenario, the number of dependancies is not...

To fix it there is a workaround: https://github.com/SamKirkland/FTP-Deploy-Action/issues/489#issuecomment-2660873337

@spaceemotion could you try? ``` const noOpLogic = function factoryNoOp() { return function compilerNoOp() { return function routeNoOp() { return true } } } const app = require('fastify')({ logger: true,...