Manuel Spigolon

Results 381 comments of Manuel Spigolon

It seems that: - we don't have a line length limit - the [no-coma-dangle](https://eslint.org/docs/latest/rules/comma-dangle) rule is not forced, so we can have mixed situation where the trailing coma is there,...

Thanks for pointing out. We should force one or another - both are confusing 🫤 Historically, we had the `no-coma-dangle` rule, so I would stick with that

> > we don't have a line length limit > > What limit do you recommend [@Eomm](https://github.com/Eomm)? I checked `standard` and it did not have such rule but I would...

I would add to the table: - `@fastify/sidecar-metadata`: it is an optional way to set some metadata on a plugin ---- I think after collecting some ideas, we could just...

We don't use any additional plugins, you need to add the https://www.npmjs.com/package/dotenv-expand one. We may implement a `plugins` option in this plugin as we did for ajv https://fastify.dev/docs/latest/Reference/Validation-and-Serialization/#ajv-plugins but I...

> we can simplify contributions and don't have to maintain TS types separately. is this the truth? I'm not a blocker here, but I want to say that I'm out...

> I believe it may not be worthwhile to pursue further investigation if the majority is opposed to it. I must say that a `fastify-plugin-ts` could make everyone happy: -...

The comparison should consider the fp's options imho: - check fastify version - check required dependancies - check required decorators

Yes, but it would require to tweak this file: https://github.com/fastify/fastify-swagger-ui/blob/main/lib/swagger-initializer.js Reference: - https://stackoverflow.com/a/44819386/3309466

I think we should drop it as in other repos