Manuel Spigolon
Manuel Spigolon
It is a C++ server if I'm not wrong, so the comparison is tricky for the reader
I think: - drop `after`: since the thenable support it is a duplicated feature imho - define better wording per `onClose`: right now its logic is the same of `ready`,...
> Could add something like - 'v*'? Yes, we always use that pattern. Maybe just `v[0-9.-]{1,8}` if we want to be stricter
> It should make sending a JSON response easier than writing: Could we say that JSON should be the "first-class" value? Then we can create a PR template of it
> Hello! Thank you for the pr! > I'm 👎 with this change because while it improves the overall developer experience, makes a quite complicated and intricated plugin developer experience....
Fastify v3 does not support ajv 8 out of the box You need to configure your server with ajv6 compatibility plugins, or follow this pr https://github.com/fastify/fastify/pull/2862 Or customizer the validator...
We don't have a release date for fastify v4 yet, but for sure it will support ajv 8 by default 👍🏼
> If you customize that mapping in ES, is that retained on restart of pino-elasticsearch? Yes, if I create manually an index and then send the logs there, the index...
I had the chance to understand better the case: - the code I linked send the logs to elastic, it doesn't create the index - elastic, cause doesn't have the...
@ly4she what version of elastic are you using? With this config: ``` docker run -d -p 9200:9200 --rm --name elastic docker.elastic.co/elasticsearch/elasticsearch:6.2.3 ``` You will get: ``` { "took": 58, "timed_out":...