Manuel Spigolon comments

Results 381 comments of


                                            Manuel Spigolon

Server crashes when using an invalid `logLevel` in route options

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

feat: improve content type read performance

I think we can propagate the code to the content-type parser as well - the target here was to be compliant with the RFC compliant first, avoid any potential bad...

Incorrect error type in `setErrorHandler`

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

fix(ts): Align routerOptions defaultRoute types with runtime

> @Eomm @gurgunday If there's anything in this PR that may need further clarification, I will be happy to rework it No, there was an internal discussion regarding this PR...

fix(ts): Align routerOptions defaultRoute types with runtime

> Just to be sure, should Fastify expose the full `find-my-way` config or only a subset of it? I will update the types and validation once that’s clear The whole...

fastify.inject crash (OOM) when stream errors after headers sent

So, we should move the issue to `light-my-request` since I can replicate with it: ```js const inject = require('light-my-request'); const { Readable } = require('stream'); const handler = (req, res)...

`addHttpMethod` override existing http standard methods

Yeah, I'm pro on supporting legacy behaviour because we can list whatever RFCs, but the real world needs to handle request body on GET handlers and blocking this feature is...

`addHttpMethod` override existing http standard methods

To recap: - `overrideHttpMethod` to override default methods (I would just check if we use `override` or `overwrite` somewhere) - `addHttpMethod` to add non-strict standard methods (+ if default method...

getNewAccessTokenUsingRefreshToken(refreshToken, params, callback) doc and signature are slightly misleading

Thanks for reporting! Would you like to send a Pull Request to address this issue?

docs: tutorials introduction

Oh, forgot to mention that we may think to move this content to the website directly instead? Just one option if we want more cool features