Manuel Spigolon comments

Results 381 comments of


                                            Manuel Spigolon

setNotFoundHandler is not encapsulated when called inside autohooks.js

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

fix: run onError hooks after error handler

> What do you mean? I mean that I would like to understand: - when was it introduced? - why did we not spot it earlier? - is the wanted...

Sponsor and repository management

> what's the recommendation in this case? This is a gray zone 😄 1. You may add them here: https://fastify.dev/organizations/#collaborators-organizations 2. ATM we list paying sponsors on this page https://github.com/fastify/fastify/blob/main/SPONSORS.md...

Fix issues with `plugin-docusaurus-v3` detecting local mode.

Can I help to get this fix shipped?

Replace 'node:stream' & 'node:util' with 'stream' & 'util'

I read: `jest-runtime` If there are some mocks, they should be updated

Migrate from tap to Node Test Runner

Could you run `npm run lint:fix`? it should fix the CI

Migrate from tap to Node Test Runner

> The issue here is using `const tmpdir = fs.mkdtempSync(path.join(os.tmpdir(), ''))` instead of the previous `t.testDir()` that was implemented directly inside tap. Do you have any suggestions about this? Perhaps...

Migrate from tap to Node Test Runner

@fastify/collaborators Please - be mindful that we should put extra care when editing the package.json

Docusaurus v3 Update

Closed by https://github.com/fastify/website/pull/223

chore: move mongodb as peer dependency

In these duplicates, you can find the workaround: https://github.com/fastify/fastify-swagger/issues/220 https://github.com/fastify/fastify-static/issues/159 The [decision](https://github.com/fastify/fastify-swagger/issues/220#issuecomment-583280362) has been to don't add it as `peerDependencies`. Since npm v10 has been released, we should re-evaluate it:...