Manuel Spigolon
Manuel Spigolon
> Notice: in the [onRequest](https://www.fastify.io/docs/latest/Reference/Hooks/#onrequest) hook, request.body will always be undefined, because the body parsing happens before the [preValidation](https://www.fastify.io/docs/latest/Reference/Hooks/#prevalidation) hook. https://www.fastify.io/docs/latest/Reference/Hooks/#onrequest Checkout the hooks execution order here: https://www.fastify.io/docs/latest/Reference/Lifecycle/#lifecycle
> the preHandler hook is called after the validation, so it should be defined right? Yes, the body is set on that time
I commented on the [doc](https://docs.google.com/presentation/d/1zPrwBVLWvjIjAjCp6ayorSQAUSjmaLl_V_vgzyyY06g/edit?disco=AAABP36DVfk) regarding a minor thing, We have 2 CDN: - Netlify for staging: https://github.com/fastify/website/blob/4f9c93e2bec54dbc140d3e2191202335d16c8bcb/.github/workflows/ci-cd.yml#L137 - GitHub Pages for prod: https://github.com/fastify/website/blob/4f9c93e2bec54dbc140d3e2191202335d16c8bcb/.github/workflows/ci-cd.yml#L110 Other than that, LGTM
Can replicate with: ```js const t = require('tap') const test = t.test const Fastify = require('.') test('Fastify should throw on wrong options', async t => { const app = Fastify()...
What is missing to this PR to get it merged?
Wrong usage of the API: ``` const form = formAutoContent( { file: fs.createReadStream(`./test/fixtures/test.txt`), }) const myHeaders = { ...form.headers, // the content-type is already added automatically Authorization: `Bearer ${jwtToken}` }...
Thanks for reporting! Would you like to send a Pull Request to address this issue?
Yeah sure, adding media is possible and we need to update this action to support it. Would you like to send a PR? > Would you know how to achieve...
I think you need to define that variable into the tweet run's env, as the twitter api key. For security reasons you need to do it, so the run can...
Here, could you try this: https://github.com/niels-van-den-broeck/FastifyV20Repro/blob/a61a4aba1f4ac64e0edfb92231a6dfb1aaef2b67/src/server.ts#L46-L47 ```diff set: (sessionId, session, callback) => { new Promise((resolve, reject) => { setTimeout(() => { - if (cancelled) reject(); + if (cancelled) { reject();...