Manuel Spigolon

Results 381 comments of Manuel Spigolon

Would you like to send a Pull Request to address this issue? Remember to add unit tests.

> I believe that getting started deserves its own section Agree > What are your thoughts @Eomm ? I would not reinvent the wheel and I would start from the...

Touched the 1 point: I meant that right now it is alphabetical order, but this order does not make sense to a new user: benchmarks should be the very last...

> If this issue is considered for resolution, I'll be happy to take on and correct this challenge. Yeah sure!

> PS: if the issue you are looking at has an empty description, it means that I'm still writing down the requirements, be patient and, meanwhile, fork the repository and...

We handle redirects here: https://github.com/fastify/website/blob/37c6deaccf70e3ddfa1bca1e6a76db78e8ea05f9/docusaurus.config.utils.js#L75 but: https://prowritingaid.com/organisation-vs-organization and the previous website stands with `organisations`: https://github.com/fastify/website-metalsmith/blob/master/src/website/content/organisations.md

Could you update the PR? we fixed the deploy to staging. Plus: why we don't add a redirect from `organizations ` to `organisations` instead? this would ease the job

This one seems implemented to me - isn't it?

`'pino-abstract-transport'` returns a Transport that is processed by the worker. So throwing an error should break some pino transport plugins I need to check how it consumes the readable stream...

> Could that be a problem? Yes, it could be: why did you add an empty parser? Just one is executed by fastify, so I think sometimes it execute this...