fastify icon indicating copy to clipboard operation
fastify copied to clipboard

Published 20 hours ago • verified publisher icon fastify

Approval Request for Future State Proposal

Open vvalderrv opened this issue 1 year ago • 20 comments
trafficstars

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the issue has not already been raised

Issue

The Linux Foundation is seeking approval of the proposal outlined in the document linked below:

Fastify Future State Proposal Please review the proposal and sign off on the plan by commenting with your approval.

If you have any further questions, please review the Transition FAQ and feel free to reach out directly.

Upon approval, The Linux Foundation will provide a detailed transition plan for your review.

Thank you for your attention to this matter. Vanessa Valderrama LF Release Engineering [email protected]

vvalderrv avatar May 16 '24 20:05 vvalderrv

attn: @fastify/leads @fastify/core

jsumners avatar May 17 '24 11:05 jsumners

Is the document required to send request before viewing?

climba03003 avatar May 17 '24 14:05 climba03003

@vvalderrv is the shared presentation locked behind an approval?

jsumners avatar May 17 '24 15:05 jsumners

Also do not have access

metcoder95 avatar May 19 '24 09:05 metcoder95

I requested the access with my gmail and got approved in a couple of minutes.

fox1t avatar May 19 '24 09:05 fox1t

A few notes:

  1. DNS, ok to move
  2. Certificates, ok to me
  3. CDN - We use Netlify for the new website. I think we should be moving this to the OpenJS Foundation Vercel account. In general, ok to transition.
  4. GitHub org - No. I'm -1 in us not having ownership permissions of the GitHub organization. I don't think this would fit for our day-to-day operation. Specifically, it would wreck my flow and (likely) willingness to do any admin work.
  5. ditto
  6. the Google Cloud function can be moved.
  7. NPM org - No. This will 100% break our ability to ship, same as 4.

Regarding GitHub org and NPM, I see no issue in adding LFIT folks to help.

mcollina avatar May 21 '24 09:05 mcollina

Hey!

I'm not a Lead (in Core Team), but I agree that GitHub and NPM org ownership change would affect efficiency badly - I think leads should keep it

I also agree that centralizing and moving infra to LF would be beneficial

So I'm ok with the rest of the proposal personally

gurgunday avatar May 21 '24 10:05 gurgunday

100% with @mcollina on this.

fox1t avatar May 21 '24 10:05 fox1t

I am not approved to see the proposal until now. So, 🤷‍♂️

climba03003 avatar May 21 '24 11:05 climba03003

on 6), I cannot see the proposal but I assume the cloud function behind https://fastify.dev/contribute/, whose code I believe is https://github.com/fastify/gh-issues-finder. We're (Nearform) no longer in charge of that, we're not hosting it and the code was moved to the fastify org years ago, so I suspect that we don't need to do anything there.

simoneb avatar May 21 '24 11:05 simoneb

Ah! So I think we are actually using that function.

mcollina avatar May 21 '24 14:05 mcollina

Ah! So I think we are actually using that function.

Unless I missed a switch from that to something else (which is not unlikely), I suspect so.

simoneb avatar May 21 '24 14:05 simoneb

Note that if it's that function, it's also used by the contributing page of Mercurius

simoneb avatar May 21 '24 14:05 simoneb

After reviewed, nothing to add 100% in sync with @mcollina

metcoder95 avatar May 29 '24 08:05 metcoder95

I apologize for the delayed response. I was unexpectedly out of the office. Thank you all for your feedback. I am updating the future state and will repost it for your review soon.

Thank you, Vanessa

vvalderrv avatar Jun 03 '24 16:06 vvalderrv

Thank you to everyone for taking the time to review and provide feedback. I have incorporated the requested changes into the future state document and am resubmitting it for your approval. Once approved, we will create a detailed transition plan aligned with the approved future state.

Fastify Future State

Thank you, Vanessa

vvalderrv avatar Jun 03 '24 20:06 vvalderrv

I am following up on my previous message regarding the future state document. Please provide an update on the status of the approval process.

Thank you, Vanessa

vvalderrv avatar Jun 10 '24 16:06 vvalderrv

@jsumners @Eomm are you on board with the amended plan? I'm +1.

mcollina avatar Jun 11 '24 09:06 mcollina

I agree with the revised plan.

jsumners avatar Jun 16 '24 10:06 jsumners

I commented on the doc regarding a minor thing, We have 2 CDN:

  • Netlify for staging: https://github.com/fastify/website/blob/4f9c93e2bec54dbc140d3e2191202335d16c8bcb/.github/workflows/ci-cd.yml#L137
  • GitHub Pages for prod: https://github.com/fastify/website/blob/4f9c93e2bec54dbc140d3e2191202335d16c8bcb/.github/workflows/ci-cd.yml#L110

Other than that, LGTM

Eomm avatar Jun 16 '24 12:06 Eomm