Manuel Spigolon

Results 381 comments of Manuel Spigolon

To review this PR, I need ~4h and I need to find such time 😮‍💨

It seems a good feature. I would take into account: - call it `validateDecodedToken` instead of `validate` - what if the user sets the `decode.complete` to false? https://github.com/fastify/fastify-jwt#decode - it...

Thanks for reporting! Would you like to send a Pull Request to address this issue?

I have this saved quick answer about this topic: > Thank you for your interest in this topic. Please see the discussion in https://github.com/fastify/skeleton/issues/42#issuecomment-1208090783 for my reasoning against such a...

Did you run benchmarks? Splitting into multiple files means 3 more accesses to the file system.

Sorry, I don't get it. Does the producer that send the message must know the consumer's queue in di case? My target would be having a silly producer that does...

The proposed solution assumes that I have control over the producer - it is not the case 😞

Would you mind to accept a PR with such a feature in case?

@timgit any chance to get a PR review? 🙏🏼