fastify-helmet icon indicating copy to clipboard operation
fastify-helmet copied to clipboard

ci: only trigger on pushes to main branches

Open Fdawgs opened this issue 2 years ago • 1 comments

See https://github.com/fastify/workflows/issues/56.

This will stop PRs from running the CI workflows twice (one for the PR and one for the push to the PR), which will cut down run times for Dependabot PRs that wait for both to complete before merging, and the time waiting for all checks to complete for normal PRs (see https://github.com/fastify/fastify-helmet/pull/195/checks).

If happy with this then i will apply to rest of the repos.

Checklist

Fdawgs avatar Aug 09 '22 06:08 Fdawgs

How about version branches?

Could add something like - 'v*'?

Fdawgs avatar Aug 09 '22 08:08 Fdawgs

Could add something like - 'v*'?

Yes, we always use that pattern.

Maybe just v[0-9.-]{1,8} if we want to be stricter

Eomm avatar Aug 16 '22 21:08 Eomm

Could add something like - 'v*'?

Yes, we always use that pattern.

Maybe just v[0-9.-]{1,8} if we want to be stricter

Doesn't appear to like the curly braces, and it's not one of the allowed values in filter list.

A suggested alternative on that page is v[0-9]+.[0-9]+.[0-9]+.

Fdawgs avatar Aug 18 '22 08:08 Fdawgs

Just nagging here: What if somebody wants to do a -rc1 suffix?

Uzlopak avatar Aug 18 '22 09:08 Uzlopak

Just nagging here: What if somebody wants to do a -rc1 suffix?

Sorted, just using 'v*' now.

Fdawgs avatar Aug 18 '22 12:08 Fdawgs

What's been the general consensus on this? Worth adding to other repos?

Fdawgs avatar Feb 09 '23 12:02 Fdawgs