fastify-helmet
fastify-helmet copied to clipboard
ci: only trigger on pushes to main branches
See https://github.com/fastify/workflows/issues/56.
This will stop PRs from running the CI workflows twice (one for the PR and one for the push to the PR), which will cut down run times for Dependabot PRs that wait for both to complete before merging, and the time waiting for all checks to complete for normal PRs (see https://github.com/fastify/fastify-helmet/pull/195/checks).
If happy with this then i will apply to rest of the repos.
Checklist
- [x] commit message and code follows the Developer's Certification of Origin and the Code of conduct
How about version branches?
Could add something like - 'v*'
?
Could add something like - 'v*'?
Yes, we always use that pattern.
Maybe just v[0-9.-]{1,8}
if we want to be stricter
Could add something like - 'v*'?
Yes, we always use that pattern.
Maybe just
v[0-9.-]{1,8}
if we want to be stricter
Doesn't appear to like the curly braces, and it's not one of the allowed values in filter list.
A suggested alternative on that page is v[0-9]+.[0-9]+.[0-9]+
.
Just nagging here: What if somebody wants to do a -rc1 suffix?
Just nagging here: What if somebody wants to do a -rc1 suffix?
Sorted, just using 'v*' now.
What's been the general consensus on this? Worth adding to other repos?