Manuel Spigolon

Results 381 comments of Manuel Spigolon

I think we should call this GH api: https://docs.github.com/en/rest/releases/releases#generate-release-notes-content-for-a-release To build the text message now

> Which files I have to edit? Here is where the npm publish is done and that one we would like to avoid: https://github.com/fastify/releasify/blob/master/lib/commands/publish.js#L122 > A unit test is required?...

I was working on it but I didn't think that if I want to release with `npm publish` I must: - login to npm, running `npm login` - provide an...

> Alternatively, if we only care about the ahead & behind properties to determine the git status, we could only compare those 2 properties. This would be harmful because the...

I think the issue is caused by the absence of the tag. If there are no tags, we should release from the first commit to head. As workaround you can...

What I see are two usages: 1. per application: a major is fine as you highlight 2. per module: a major is not (always) fine because the module may simple...

As workaround, could you try to use a custom developer token instead of the default GITHUB_TOKEN?

After reading the [GH docs](https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token) it seems not doable by setting some config. Maybe we could add an extra step to trigger a workflow by calling the [`/repos/{owner}/{repo}/actions/workflows/{workflow_id}/dispatches`](https://docs.github.com/en/rest/reference/actions#create-a-workflow-dispatch-event) API to...

> Hi, I just stumbled across this problem too and from my point of view I would have no problem specifying the workflow I want to call. Is there an...

Released in v10 https://github.com/fastify/session/blob/16ef7eb6c79ecc2342b0611c3aebb2512ca0c24c/types/types.d.ts#L84