Manuel Spigolon

Results 381 comments of Manuel Spigolon

The CI is green https://github.com/fastify/fastify-rate-limit/actions/workflows/ci.yml So there should be something here that has changed some function order execution I can't debug this PR very soon What I would do is:...

it was a code example, you need to use your own function `keyGenerator` and `allowList`

I think it can do it because of money. Vercel pays devs to work on the Next.js framework full-time. > [Vercel raises $150M Series D as it looks to build...

I think the source of the issue starts from here: https://github.com/nodejs/node/issues/36005 and leads to the [`chokidar`](https://github.com/paulmillr/chokidar/commits/HEAD) module's funding If we drop that module, we should go for the `node:fs.watch` one

> So again: I totally disagree with adding a non-standard json-schema type. Yes, I'm with you. This would break everything: - swagger - open api - fluent-schema and every JSON...

the `uniqueItems` option has been added in Draf 8 version of the JSON Schema. So we can't relay on it. I thought the issue here was: When a user wants...

You need one more check ```diff diff --git a/index.js b/index.js index 8939e92..275e9ab 100644 --- a/index.js +++ b/index.js @@ -475,6 +475,9 @@ function addIfThenElse (location, input) { elseLocation.schema = merge(schema, elseSchema)...

> if I convert everything to an array anyway That is needed because we use `ajv` to apply the `oneOf` and `anyOf` validations. So that code is needed by ajv....

> remember that you shouldn't modify the original object Instead of replacing the value, we could add a symbol with the Array to access later

The main topic is that fjs has always provided a simple function that does all the work. To do what you propose we need to move to an interface like...