Jacob Finkelman

Results 313 comments of Jacob Finkelman

Good to know! I will have to rerun when I get a chance. The most likely explanation is a random hiccup on my computer, that's pretty likely when carefully measuring...

A more targeted run, that only looked at crates containing the word `solana` went from 180.61min from master to 162.47min on this PR. With this run `solana-core v1.0.5` went from...

I wanted to spend some time teasing apart exactly what part of the old hash was slow. The old hash but modified to hash the pointer of the `InternedString` instead...

So I was able to get about 50% of benefit was much less churn. I change the order so that we only do the `Eq` test for `SourceId` after the...

I had to run a `fetch` before I could get the problem to reproduce. Another symptom of this problem is that `cargo generate-lockfile && cargo check --locked` returns an error....

I have fixed all known (to me) real world slow cases in the resolver. There are still synthetic ones (#6258) but there pretty pathological. I don't remember a specific fix...

There are many people that have downloaded all the crates and can get us a size by file type histogram. Adding a comment about this to the instructions for publishing...

Experimented with this branch, definitely found cases I was not expecting. For example the requirement `>=0.24,

Thanks for the update! I tried again and found more examples that didn't match my expectations: - `=4.1` with `4.1.1-rev.0` - `^4.5` with `4.5.0-alpha.1` - `~0` with `0.1.0-0` - `=4.2`...

Thanks for the update! `req(">= 4.1") == req(">= 4.1.0") not match "4.1.0-rev.0"` feels really odd to me. Intuitively it looks like `=4.1` should match something that starts `4.1`. So perhaps...