Jacob Finkelman

This is a grate test case! It will need to wait for us to support most of Cargos features (multiple versions per crate, links attributes, and features) to be sure...

There's a lot of context I missing here. But fundamentally you looped me in about '"transform" a PubGrub `State` in the middle of the resolution'. This is not exposed in...

Thank you for doing that! With this revision, I'm looking forward to reviewing it :-P. It seems very useful for this library to provide example implementations of the traits it...

Those are very impressive numbers. Thank you for looking into this! I appreciate getting to see the unified vision of where everything is going. Obviously, with this much going on...

Those are very exciting numbers! What piece do you want to work on next? The first of your commits is https://github.com/pubgrub-rs/pubgrub/pull/274/commits/58340832df9029c8e239af18b1e4bd4f054af5e9 `Move offline provider into a separate module` which I've...

10% on only resolution micro benchmarks leading to 1% on a end-to-end test makes sense if we are spending about 10% inside resolution code.

The `display()` method is a very good idea. I copied that for `Incompatibility`, and `PartialSolution`. Thank you. So far `External` still holds `P` so does not need special handling. I...

I don't have enough context to interpret that issue. - What do you end up using this information for? - Why can't it be reconstructed from `dp.get_dependencies` (whatever your internal...

> We can reconstruct it, but since pubgrub already knows the graph we should be able to read it out instead of reconstructing it on our side. pubgrub does not...

Ironically, today in my work trying to model cargoes resolver with pubgrub I minimized a clear example of [cyclic package dependencys](https://github.com/rust-lang/cargo/blob/4dcbca118ab7f9ffac4728004c983754bc6a04ff/src/cargo/core/resolver/mod.rs#L1006) which requires looking at pubgrub's output as a graph....