Jacob Finkelman

Results 313 comments of Jacob Finkelman

Sorry I did not get time to respond to you yesterday. > What exactly constitutes adding a package to the bill? "bill" was a typo for "build". You kind of...

As to testing... You should definitely add a couple normal tests [here](https://github.com/pubgrub-rs/pubgrub/blob/dev/tests/tests.rs), that check for the basic semantics of your new API. If a package is only mentioned in constraints,...

> I understand what to do with the SAT test but Im struggling with how to express "and no other versions are selected". Looking at the varisat crate also didn't...

I love this idea. Of course, subtle misuses of your knowledge database can lead to incorrect output. For example, if you are attempting to update the database because the "dependency...

I don't fully understand the distinctions between `incompatibilities` and `incompatibility_store` and so dont get how it helps here. Can you elaborate?

Thank you for the great write ups! This is a lot clearer now.

So it sounds like there are big wins by just merging ones that are exactly the same, without doing anything "smartly". Or even better figuring out how not to generate...

This is functionality we do not yet have. Can we keep it open?

For future reference, I think the relevant code in dart is [`_dependencyBounds` in `package_lister`](https://github.com/dart-lang/pub/blob/master/lib/src/solver/package_lister.dart#L348). Although it is not as sophisticated as what we have already described.

Specifically, what is your practical use case? I want to make sure that whatever we design is ergonomic for real world needs.