Jacob Finkelman

Results 313 comments of Jacob Finkelman

Yes, `union` is linear in the length of the ranges being merged so doing it in a loop is quadratic. The fundamental `union` algorithm is: 1. Create a combined list...

Yes. `smaller_interval` is "among all non-exhausted iterators pick the first segment from the one who's got the smallest start point". If we had a `IterWithOrdBySmallestStart` then we could calculate `smaller_interval`...

cc https://github.com/pubgrub-rs/pubgrub/issues/114

fixed in https://github.com/pubgrub-rs/pubgrub/pull/240

Looking more closely at both examples, they should clearly be panics. For the first one it's not even clear how this could be a user's fault, something in the algorithm...

Seems reasonable. That all sounds good.

Leaving open for the ErrorChoosingPackageVersion vs choose_version inconsistency.

Thank you all for doing work on this. I am going on vacation and will not be able to look at or think about this for 2 weeks. One open...

What is a `virtual repository` in this context? If you don't want your registry to allow crates that have arbitrary sources, why can't you check that at publish time?

Registries that mix crates from multiple sources are going to hit this problem. The current workaround is to use source replacement (specifically at published time) so that all crates claim...