Egor Bogatov
Egor Bogatov
Prototype: https://github.com/EgorBo/runtime-1/commit/1c73b3efbaee85147278e307ec04b19ccc618620
In case of `dotnet publish` and `"true"` `"false"` it's  I assume it's here: https://github.com/dotnet/msbuild/blob/3ade6423189769545ddff2ffeeed37010ec57f4d/src/Build/Evaluation/Conditionals/Scanner.cs#L561-L641
Still, I think at least these two lines of code worth adding: https://github.com/EgorBo/runtime-1/blob/c487556f0a1131833ce22dfe40cb89fca88b5dcf/src/libraries/System.Private.CoreLib/src/System/String.Manipulation.cs#L1850-L1854 - cheap handling for '0'..'9', right? `UInt32ToDecStr` does: https://github.com/dotnet/runtime/blob/7f9ed8f271df8fb83862b3812d9c490e4ff74711/src/libraries/System.Private.CoreLib/src/System/Number.Formatting.cs#L1594-L1603
Thanks for the feedback, I'll check if it's worth special-casing on msbuild's side > We used to intern some hard coded strings like true and false in MSBuild including in...
Failure is https://github.com/dotnet/runtime/issues/73247
> Does this PR also cover crossgen2? Yes works for R2R. And, probably, for NativeAOT as well but afair it redirects stdout cc @MichalStrehovsky
One noticeable advantage over sharplab for end-users is the ability to print names for helper calls, e.g. ```csharp public class C { object o; public void M(object[] a) { a[0]...
> @EgorBo do you plan to merge this to .NET 7? It probably does not meet the bar but I'd love to merge it in .NET 7.0, but no strong...
> no concerns about the data this exposes Yep, we discussed this one too and came to conclusion that there is nothing to be afraid of and our competitors provide...
> You have to specify the option on the command line instead of env variable. Is that correct? Correct, e.g. `--codegenopt NgenDisasm="Test"` > We should not be injecting new life...