Egor Bogatov

Results 218 comments of Egor Bogatov

> > We should probably run most relevant pipelines on this. > > Note that we do little to no testing with Release builds (except the checked/release asm diffs pipeline),...

Outerloop pipelines failures seem unrelated: - Fuzzlyn: same here, e.g. x86 failure is https://github.com/dotnet/runtime/issues/70786 - `coreclr Pri0 Runtime Tests Run Linux arm checked` failure is https://github.com/dotnet/runtime/issues/73247 - `runtime-coreclr crossgen2 outerloop`...

> My main concern would be that we have an idDebugOnlyInfo() use somewhere that is not conditioned on the debug info being present, but I've audited the uses and wasn't...

@dotnet/jit-contrib @jakobbotsch @BruceForstall PTAL

> Seems like we should allow users to specify `JitDiffableDasm` too? > > If you are live debugging it would be nice to see the actual addresses and such. >...

> @EgorBo Can we assume that it will always start with `"; Assembly listing for method "` and end with `"; Total bytes of code "`? Good question, I assume...

Merging now. We're going to keep eyes on TP-related benchmarks (e.g. "Crossgen2 Throughput Trends" page) in coming weeks. Kudos to @jakobbotsch for mitigating all the initial TP/Memory regressions 🎉

Judging by the stacktrace and the job itself it's mono-interp

@am11 we had some issues with it and fixed them yesterday, can you rebase your PR?

Current results: ![image](https://user-images.githubusercontent.com/523221/174455917-b11d13e2-5105-40cb-b65f-a0b39238a181.png) Both `base` and `diff` use a locally built coreclr that matches SDK (latest daily) and both use `DOTNET_TieredPGO=1`. `base` results match the official results - OK. `diff`...