Edwin Guzman

Results 9 issues of Edwin Guzman

#### This issue is a Bug #### Related issue *Example: See also #388 * #### Observed behavior We tested this on the debugger using Readium's `Readium_cloud-reader-lite.zip` (hosted here: https://readium.org/technical/technical-notes/_posts/testing-with-cloudreader/) Under...

Fixes JIRA ticket [DSD-1742](https://jira.nypl.org/browse/DSD-1742) ## This PR does the following: - Fixes the selected item count button's z-index issue. ## How has this been tested? Storybook, specifically check the layout...

Needs Review

Fixes JIRA ticket [DSD-1729](https://jira.nypl.org/browse/DSD-1729) ## This PR does the following: - Adds the `showRowDividers` prop to be able to hide horizontal row dividers for the `"dl"` `List` variant. - The...

Needs Review
Questions

Fixes JIRA ticket [DSD-1748](https://jira.nypl.org/browse/DSD-1748) ## This PR does the following: - Adds interaction tests for the `RadioGroup` component. It checks for both clicking on radio inputs and using up/down and...

Needs Review

Fixes JIRA ticket [DSD-1565](https://jira.nypl.org/browse/DSD-1565) ## This PR does the following: - There was a duplicate snapshot test for the `Breadcrumbs` component that used the same type value. It was updated...

Needs Review

Fixes JIRA ticket [DSD-1735](https://jira.nypl.org/browse/DSD-1735) ## This PR does the following: - Exports `chakra` and `useMediaQuery` chakra functions. Some consuming apps (such as the Header app) use these helper functions. ##...

Needs Review

Fixes JIRA ticket [DSD-1582](https://jira.nypl.org/browse/DSD-1582) ## This PR does the following: - Updates the `TextInput` and `SearchBar` components to better associate the input element to the entire component's helper text. This...

Needs Review

Fixes JIRA ticket [DSD-1766](https://jira.nypl.org/browse/DSD-1766) ## This PR does the following: The original intention for this ticket was to remove and update some packages that were causing security issues, namely `tough-cookie`...

Needs Review
x2

This updates the Github Actions standards file to include script examples in Digital for running unit tests and deploying to AWS. This could use more examples from other projects so...