nypl-design-system icon indicating copy to clipboard operation
nypl-design-system copied to clipboard

Published 20 hours ago • verified publisher icon NYPL

DSD-1582: better association between the SearchBar's helper text and input element

Open EdwinGuzman opened this issue 9 months ago • 1 comments

Fixes JIRA ticket DSD-1582

This PR does the following:

  • Updates the TextInput and SearchBar components to better associate the input element to the entire component's helper text. This is done by overriding the TextInput's internally generated aria-describedby value when there is an explicit value added through the aria-describedby prop.

How has this been tested?

Storybook

Accessibility concerns or updates

  • This was flagged as "Descriptive text is not programmatically associated (major)"

Checklist:

  • [ ] I have updated the Storybook documentation accordingly.
  • [ ] I have added relevant accessibility documentation for this pull request.
  • [ ] All new and existing tests passed.

Front End Review:

  • [ ] Review the Vercel preview deployment once it is ready.

EdwinGuzman avatar May 13 '24 15:05 EdwinGuzman

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nypl-design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 3:33pm

vercel[bot] avatar May 13 '24 15:05 vercel[bot]

Bump for review @jackiequach @7emansell @oliviawongnyc

EdwinGuzman avatar May 21 '24 20:05 EdwinGuzman