Dsd 1766/npm package update

[EdwinGuzman]

Fixes JIRA ticket DSD-1766

This PR does the following:

The original intention for this ticket was to remove and update some packages that were causing security issues, namely tough-cookie and vite. This then turned into updating Storybook to 8.0.8 and related packages.

• Adds the following npm packages: jest-transformer-svg, @storybook/addon-designs, and @storybook/test.
• Updates the following packages:
  • Storybook main package and related libraries to 8.0.0.
  • remark-gfm to 4.0.0.
  • vite to 5.2.8, @vitejs/plugin-react to 4.2.1, and vite-plugin-svgr to 4.2.0.
• Updates how SVGs are imported into LogoSvgs.tsx and IconSvgs.tsx.
• Updates Storybook internal link and heading styles and enables the hash heading URL linking.
• Removes the following packages: downshift, tough-cookie, @storybook/testing-library, storybook-addon-designs, and @svgr/webpack.

How has this been tested?

To test this locally, remove node_modules and package-lock.json and reinstall packages.

Storybook. Please review all pages.

Accessibility concerns or updates

• N/A

Checklist:

• [ ] I have updated the Storybook documentation accordingly.
• [ ] I have added relevant accessibility documentation for this pull request.
• [ ] All new and existing tests passed.

Front End Review:

• [ ] Review the Vercel preview deployment once it is ready.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nypl-design-system	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2024 11:47pm

[EdwinGuzman]

@bigfishdesign13 @7emansell @oliviawongnyc @jackiequach please review this soon if possible, thanks!

[EdwinGuzman]

@jackiequach thanks! Good catch on all the issues. Some were things we missed, most likely in the react 18/charka 2.8 upgrade. Everything you flagged should be fixed except for:

I'm seeing some slowness (locally) when going into doc pages, which seems to stem from the tests for the component running on load.

Is it all doc pages or some?

[EdwinGuzman]

Also, the autocomplete SearchBar example has not been working for a very long time. We'll have to fix that some time soon but not right now.

[EdwinGuzman]

The changes look good. The slowness was across all components when I tested locally.

Yes, and it was related to the local test json file. It was so slow when I initially tested and it was quite annoying. I did not really change anything and then it was running faster for me.