Edwin Guzman
Edwin Guzman
Ready for another review @7emansell @jackiequach @bigfishdesign13
Adding @7emansell as a draft reviewer since she knows `FeaturedContent` very well. Emma, this is what I'm thinking about when reviewing this draft: at some point, the DS and maybe...
This looks great! I think you and @oliviawongnyc should create a working feature branch where all work in progress and reviewed code can go into. This bigger feature branch would...
Ah yes, I forgot to bring that up. Since the default is already set to `true`, it's hard to know when it is explicitly passed by the consumer. So we...
The logic is not straightforward and I prefer to make that a new ticket if we really want it. In my opinion, the dev should use the doc to know...
Bump for review @jackiequach @7emansell @oliviawongnyc
@bigfishdesign13 @7emansell @oliviawongnyc @jackiequach please review this soon if possible, thanks!
@jackiequach thanks! Good catch on all the issues. Some were things we missed, most likely in the react 18/charka 2.8 upgrade. Everything you flagged should be fixed except for: >...
Also, the autocomplete `SearchBar` example has not been working for a very long time. We'll have to fix that some time soon but not right now.
> The changes look good. The slowness was across all components when I tested locally. Yes, and it was related to the local test json file. It was so slow...