Dominic Clark
Dominic Clark
CPack/NSIS saves the chosen Start Menu folder in the registry, and uses this as the default folder for future installations. If 1.1.3 was installed previously, then "LMMS 1.1.3" will be...
The installer title is [controlled](https://gitlab.kitware.com/cmake/cmake/-/blob/v3.29.6/Modules/Internal/CPack/NSIS.template.in?ref_type=tags#L34) by [`CPACK_NSIS_PACKAGE_NAME`](https://cmake.org/cmake/help/latest/cpack_gen/nsis.html#variable:CPACK_NSIS_PACKAGE_NAME), which [defaults](https://gitlab.kitware.com/cmake/cmake/-/blob/v3.29.6/Modules/CPack.cmake?ref_type=tags#L841) to [`CPACK_NSIS_DISPLAY_NAME`](https://cmake.org/cmake/help/latest/cpack_gen/nsis.html#variable:CPACK_NSIS_DISPLAY_NAME) if the latter is set but not the former. We [set the latter](https://github.com/LMMS/lmms/blob/39b7d16f15f20c429e264040547755afda7eac98/cmake/nsis/CMakeLists.txt#L11) to `"${PROJECT_NAME_UCASE} ${VERSION}"`, which evaluates to...
My guess (not tested) would be that this line should use `Engine::getSong()->getTimeline(Song::PlayMode::Song)`, not `m_timeLine`: https://github.com/LMMS/lmms/blob/f3d3a1421e2f4eb7d8dd8b35fdef1e8df2cd2cf8/src/gui/editors/PianoRoll.cpp#L284
The sorting function looks good, but it only appears to be applied to root directories. Would you be able to apply it to all file browser entries?
For MinGW builds, the `mingw-std-threads` submodule triggers a deprecation message, so I had to make deprecation messages warning only there. It should be possible to remove the `-Wdeprecated` flag with...
> Configure warnings (more than just this one) These are known about, and are in third-party code that I'm not trying to fix. See my comment above.
#1195 refers to the playhead. This issue is about having a scrollbar in the B+B editor, so we don't have to scale the editor to make it all fit in...
Another issue I can see is fitting this around the instrument's built-in effect chain, which is only able to process a single stream of audio. Should we offer the option...
Certainly that would be ideal, but that may be difficult or impossible to implement. Playing each stream through the same chain won't work (imagine, say, a reverb effect where the...
Can we preserve the knob labels? I think it would be clearer that way. Also, how about making the effect buttons more consistent in style to the track buttons (i.e....