Dominic Clark

Results 106 comments of Dominic Clark

Since you're no longer modifying the graph code, could you revert the formatting changes there?

> Yes, but it's harder. Compare it to pitch bend vs pitch bend range. It is slightly redundant, but it increases ease of use, especially in automation. 👍 > The...

It doesn't look to me like the modulator gets synced back to the original frequency any more. Here's the only place where the modulator's phase is modified, and it's just...

Ah yes, I see. I thought `sample_index[1]` was the phase after sync had been applied, but it's the phase before. Thanks for clearing that up.

I'd rather we used `std::exp2`, which will operate at the appropriate precision for its argument, than `std::exp2f`, which causes its argument to be implicitly converted to a float. Also, in...