Dominic Clark

Results 106 comments of Dominic Clark

I've had a look at what some other DAWs do and it turns out FL also uses the `WS_CHILD` trick, so it should be safe to include. JUCE issue opened...

> Maybe it's best to fix this on our side as you've suggested? Sure. Although I think this should go into master, not stable-1.2, since Lukas-W wants #2826 in master...

Milestoned for 1.3. In the meantime please use "No embedding" for the "Plugin embedding" option as a workaround.

@jpcima This bug should manifest itself in any host which bridges plugins and embeds plugin UIs in the host's main window, unless it specifically works around the issue (e.g. FL...

The following patch works on Windows, but I haven't tested it on Linux yet. PhysSong reports that the bug doesn't occur on Linux, so it may not need to be...

I tested Sylenth1 some more. I was able to determine that it uses JUCE, and that its menu bug is caused by the same buggy JUCE code. However, this new...

JUCE have fixed the bug on their end: https://github.com/juce-framework/JUCE/issues/401#issuecomment-856914463. Do we still want to try and work around this, or should we assume most plugins will update and embedding can...

What should we do for plugins? Some options: * Root LMMS namespace `lmms::` * Shared plugin namespace `lmms::plugin::` * Individual namespaces `lmms::tripleoscillator::` * Individual namespaces in plugin namespace `lmms::plugin::tripleoscillator::` Long...

@Mayravixx That version doesn't contain the code from this PR - it's instead the latest `master` version (see the commit hash in the title bar - 8a9a2fae6).

I feel like the switch to `std::optional` is a bit out of scope for what is otherwise a tiny change. There's a bunch of other modernisation to be done across...