Dominic Clark

This fixes SDL2: ```diff diff --git a/cmake/modules/FindSDL2.cmake b/cmake/modules/FindSDL2.cmake index 3bad1002e..6e07f7aff 100644 --- a/cmake/modules/FindSDL2.cmake +++ b/cmake/modules/FindSDL2.cmake @@ -33,6 +33,18 @@ find_package(SDL2 CONFIG QUIET) if(TARGET SDL2::SDL2) + # SDL2::SDL2 under MinGW is...

Unfortunately not - `objdump` is run from the install script, so `CMAKE_FIND_ROOT_PATH` isn't set there. I also tried deducing it from the search paths we already pass for dependencies, but...

The `GetPrerequisites` module we use for finding dependencies has been deprecated in CMake 3.16 in favour of `file(GET_RUNTIME_DEPENDENCIES)`. While this still uses `objdump` (or equivalents on other platforms) behind the...

That's equivalent to `install(CODE)`, which is what it uses internally. It was written in order to use generator expressions with `install(CODE)` while still supporting CMake < 3.14, falling back to...

VST3 is VST in name only - as far as the code goes, it's as different to VST2 as something like LV2 or LADSPA is. I don't think it's meaningful...

> For all kinds of data, from projects to plugins to samples, LMMS currently manages most of its saving and loading of that data through the `DataFile` class. I don't...

> The idea of having the handles be allocated on the heap as the heart of our audio processing is flawed on a fundamental level. I was thinking of designing...

> I thought of other designs such as one based on pre-allocated audio nodes and a dependency graph and wondered if that'll make things easier/better That's certainly a good idea,...

Restoring the cache will create the `build` directory, so `mkdir` will fail. `2> /dev/null` will discard any error message, but the exit code will still be non-zero. Try using `mkdir...

@sakertooth's comment at https://github.com/LMMS/lmms/pull/7170#issuecomment-2035648962 still applies. While passing a pointer to a `std::vector` doesn't leave us any worse off than passing a pointer to a `ValueBuffer`, if we actually want...