numcodecs icon indicating copy to clipboard operation
numcodecs copied to clipboard

Apply repo-review suggestions

Open DimitriPapadopoulos opened this issue 1 year ago • 4 comments

https://learn.scientific-python.org/development/guides/repo-review/?repo=zarr-developers%2Fnumcodecs&branch=main

TODO:

  • [ ] Unit tests and/or doctests in docstrings
  • [ ] Tests pass locally
  • [ ] Docstrings and API docs for any new/modified user-facing classes and functions
  • [ ] Changes documented in docs/release.rst
  • [ ] Docs build locally
  • [ ] GitHub Actions CI passes
  • [ ] Test coverage to 100% (Codecov passes)

DimitriPapadopoulos avatar Aug 10 '24 11:08 DimitriPapadopoulos

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.91%. Comparing base (3b86d9c) to head (3780e1f). Report is 65 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #559   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          59       59           
  Lines        2332     2332           
=======================================
  Hits         2330     2330           
  Misses          2        2           
Files with missing lines Coverage Δ
numcodecs/__init__.py 100.00% <100.00%> (ø)
numcodecs/astype.py 100.00% <100.00%> (ø)
numcodecs/bitround.py 100.00% <ø> (ø)
numcodecs/bz2.py 100.00% <100.00%> (ø)
numcodecs/categorize.py 100.00% <100.00%> (ø)
numcodecs/checksum32.py 100.00% <100.00%> (ø)
numcodecs/compat.py 100.00% <100.00%> (ø)
numcodecs/delta.py 100.00% <ø> (ø)
numcodecs/fixedscaleoffset.py 100.00% <ø> (ø)
numcodecs/json.py 96.07% <ø> (ø)
... and 41 more

codecov[bot] avatar Aug 10 '24 11:08 codecov[bot]

Thanks, @DimitriPapadopoulos, but would you also be willing to apply this to the v3 branch? v2 (main) is entering maintenance mode: https://zarr.dev/blog/zarr-python-v3-update/

joshmoore avatar Aug 26 '24 19:08 joshmoore

There is no v3 branch in numcodecs, is there? This is numcodecs, not zarr-python.

DimitriPapadopoulos avatar Aug 27 '24 19:08 DimitriPapadopoulos

:facepalm: Apologies, @DimitriPapadopoulos. You are of course correct. Sorry for the noise.

joshmoore avatar Aug 29 '24 06:08 joshmoore