Daniel Sinclair

Results 107 comments of Daniel Sinclair

@JacobHomanics Which dApp and type of transaction were you attempting to sign in that scenario? Will investigate!

@derHowie The "should be able to favorite a token and check the info button is present" e2e test oddly seems to be failing; not sure why

@derHowie Seeing the same failure; the CI screenshot doesn't show any assets but looks like the output modal is still presenting. Is there maybe a new network hang that causes...

@magiziz Can you have a look at the issue Chris mentioned? Can get this merged this week

Merging per Chris's recommendation about the token cell update issue. Created a follow-up ticket for that

@BrodyHughes Few pieces of feedback: - We actually want to keep the Firefox runner for the sanity checks, but only run the Firefox suite (just Onboarding tests) on merges to...

@BrodyHughes Do we still like all of these changes, or want to close?

Moving to draft until we make progress with Ledger SDK issues

@BrodyHughes Looks like Firefox errors are still popping up here; oddly only on that platform.

Seeing a similar error with the same test case: `Trigger Cmd K -> Paste contract address for unowned token 0xdac17f958d2ee523a2206206994597c13d831ec7 -> Crash` > React Router caught the following error during...