browser-extension icon indicating copy to clipboard operation
browser-extension copied to clipboard

hidden assets for magic menu (CmdK)

Open 0xmkh opened this issue 1 year ago • 2 comments

Fixes BX-1377 Figma link (if any):

What changed (plus any additional context for devs)

  • Added hide/unhide action for tokens and nfts in CmdK magic menu.
  • Added "Hidden" label to hidden tokens and nfts. Similar to "Watching" label for watched wallets.
  • Searching "hidden" in CmdK menu will show hidden assets.

Screen recordings / screenshots

https://github.com/user-attachments/assets/a3b0e595-b268-4349-9f85-7db3b7050281

What to test

Make sure hide and unhide actions work with tokens and nfts in CmdK menu.

0xmkh avatar Aug 13 '24 12:08 0xmkh

Hide/unhide functionality works, but if you pull up the cmd-k menu while you're on the assets list then return after hiding a token, the list's rendering seems to be messed up when you scroll. Sometimes there are blank gaps and sometimes there are overlaps. I'm guessing this means the keys are getting messed up or the new list needs a .measure() call after you hide/unhide something.

derHowie avatar Aug 13 '24 16:08 derHowie

@magiziz Can you have a look at the issue Chris mentioned? Can get this merged this week

DanielSinclair avatar Aug 20 '24 17:08 DanielSinclair

@derHowie is this ready for review?

estebanmino avatar Sep 09 '24 17:09 estebanmino

@derHowie is this ready for review?

yes

derHowie avatar Sep 09 '24 17:09 derHowie

Merging per Chris's recommendation about the token cell update issue. Created a follow-up ticket for that

DanielSinclair avatar Oct 05 '24 04:10 DanielSinclair