ledger clear signing upgrades
Fixes BX-#### Figma link (if any):
What changed (plus any additional context for devs)
- upgraded
@ledgerhq/hw-app-ethand@ledgerhq/hw-transport-webhid - removed patch and
static/json/ledgerdynamically imported files
Follow ups
- evaluate alternative performance optimizations after removing dynamic json imports
- create a wrapper around
@ledgerhq/packages with a dynamic runtime module linking so that we can import the Ledger module and JSON files as needed, without creating overhead on boot or for wallets that don't use a Ledger device. This will be easier to coordinate more frequent Ledger SDK upgrades required for Clear Signing
Screen recordings / screenshots
What to test
- Performance of boot/signing before and after ledger upgrades (with or without device paired)
- Pairing and Signing with Ledger devices. Should try on a Ledger with an older firmware version and a recent firmware version (this month)
- Signing for popular dApps like Lido or Uniswap should not display a Blind Signing warning (new aggressive warning)
- Bruno: Firefox bundle size might be too large; need to check sizes or disable bundling for Firefox. Should discuss bundle size improvements with Ledger.
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
| Package | New capabilities | Transitives | Size | Publisher |
|---|---|---|---|---|
| npm/@ledgerhq/[email protected] | None | 0 |
62 MB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
222 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
142 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
205 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
131 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
2.16 MB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
107 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
74.3 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
132 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
262 kB | ldg-github-ci |
| npm/@ledgerhq/[email protected] | None | 0 |
372 kB | ldg-github-ci |
🚮 Removed packages: npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/@ledgerhq/[email protected], npm/[email protected]
Here's the packed extension for this build: rainbowbx-2670aab407ab027138eef8761ddd3a7f41e52519
Here's the packed extension for this build: node_modules.tar.gz rainbowbx-661b1371eef876b0b655d7a481a0f84298449e35
Here's the packed extension for this build: node_modules.tar.gz rainbowbx-661b1371eef876b0b655d7a481a0f84298449e35
Tried a swap and got stuck here:
Tried a send and got stuck after hitting the send action button. Will dm u the console logs.
Here's the packed extension for this build: node_modules.tar.gz rainbowbx-5064422db113513c824a15a95ed57c2826688051 screenshots
Moving to draft until we make progress with Ledger SDK issues