browser-extension icon indicating copy to clipboard operation
browser-extension copied to clipboard

ledger clear signing upgrades

Open DanielSinclair opened this issue 1 year ago • 6 comments

Fixes BX-#### Figma link (if any):

What changed (plus any additional context for devs)

  • upgraded @ledgerhq/hw-app-eth and @ledgerhq/hw-transport-webhid
  • removed patch and static/json/ledger dynamically imported files

Follow ups

  • evaluate alternative performance optimizations after removing dynamic json imports
  • create a wrapper around @ledgerhq/ packages with a dynamic runtime module linking so that we can import the Ledger module and JSON files as needed, without creating overhead on boot or for wallets that don't use a Ledger device. This will be easier to coordinate more frequent Ledger SDK upgrades required for Clear Signing

Screen recordings / screenshots

What to test

  • Performance of boot/signing before and after ledger upgrades (with or without device paired)
  • Pairing and Signing with Ledger devices. Should try on a Ledger with an older firmware version and a recent firmware version (this month)
  • Signing for popular dApps like Lido or Uniswap should not display a Blind Signing warning (new aggressive warning)
  • Bruno: Firefox bundle size might be too large; need to check sizes or disable bundling for Firefox. Should discuss bundle size improvements with Ledger.

DanielSinclair avatar Jul 29 '24 19:07 DanielSinclair

Here's the packed extension for this build: rainbowbx-2670aab407ab027138eef8761ddd3a7f41e52519

github-actions[bot] avatar Jul 29 '24 20:07 github-actions[bot]

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-661b1371eef876b0b655d7a481a0f84298449e35

github-actions[bot] avatar Jul 30 '24 06:07 github-actions[bot]

Here's the packed extension for this build: node_modules.tar.gz rainbowbx-661b1371eef876b0b655d7a481a0f84298449e35

github-actions[bot] avatar Jul 30 '24 07:07 github-actions[bot]

Tried a swap and got stuck here: Screenshot 2024-07-31 at 1 42 51 PM Tried a send and got stuck after hitting the send action button. Will dm u the console logs.

BrodyHughes avatar Jul 31 '24 18:07 BrodyHughes

Moving to draft until we make progress with Ledger SDK issues

DanielSinclair avatar Aug 21 '24 05:08 DanielSinclair