Daniel Sinclair

Results 107 comments of Daniel Sinclair

@derHowie Wasn't totally sure of the context either. I looked at the merge conflicts on Friday, but there are quite a few following Popular in Rainbow

Go for it 🫡

Moved to draft while we workout the Backend change

Closing for now because I assume Backend will handle this fix

@magiziz Want to pick this one back up?

@magiziz Available to push this to the finish line?

Moving to draft since this might conflict with the Popular on Rainbow changes and may no longer be necessary; will clear that up this week

Hi @stephancill. Thank you for highlighting this. We currently don't inject our provider into iframes because of known vulnerabilities with this approach that wallets have experienced in the past. But...

@serg-plusplus Can you enable "Allow edits from maintainers"? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

@serg-plusplus Okay. I think the only change we need is to revert the locale changes and just keep`en-US`; that is managed by our translation system.