Daniel Gibson

Oh right, regarding the half-way points: I think in general the first version is more logical: The user maps values out of the 0..255 range to the appropriate values supported...

> The comparison that comes to my mind is the lighting in my home. The brightness of all of them is controlled in a percentage from [0..100]%. All of these...

I have a question about the following code in computePwmMap(): https://github.com/markusressel/fan2go/blob/007c90877588847d0e5fe58f85642d57b94602e1/internal/controller/controller.go#L706-L711 Why `if ... && f.pwmMap != nil {` ? Why does it matter if it's `nil` if it gets...

I implemented an `AlwaysSetPwmMode` option for fans. If set to true, it sets the PWM Mode / ControlMode each cycle (like before), otherwise (and by default) it doesn't. Also added...

I added documentation for the new options and rebased to current master

Ok, then I'll keep those periodic checks for another PR and just do some more (manual) testing of this stuff. I think it should be in a good shape generally,...

BTW, I think it would be good to have that periodic check (from a future PR) in version 1.0.0 - it could solve that potential "fan might not be in...

> > > Yes, but I am not sure what kind of interpolation corresponds to "finding the closest value". Or do you want to suggest something else? > > >...

> I will run the current state of the branch on two of my machines for a couple of hours or days to test things out, but first results look...

Check out #27 - it introduces a new way to tell devices apart by looking at the available PCI devices (in addition to DMI vendor/product name) - maybe that could...