Daniel Gibson

I think this is ready for review. I think potential tweaks for the LEDs don't impair that - they should only affect a few lines in the `asustor_fs6700_gpio_leds_lookup` table, which...

Damn, you're right, sorry! I must've been tired when I did those changes.. Will undo them.

Fixed (force-pushed the commits without that change) @romracer: Does this code, esp. the detection, work for you as well? Just to make sure the different BIOS version doesn't break it.....

The disk triggers won't work with the FS67xx, because they don't work with NVME drives at all, see https://github.com/mafredri/asustor-platform-driver/pull/21#issue-2462378011 > Lastly, these units are all NVMe devices, and the default...

If the usb-host trigger works but others don't then that sounds more like an issue with the triggers than with "our" kernel modules. I just tested the green status LED...

> Does setting to 0 turn it on No, I tried both 0 and 1. I had to do the aforementioned change to `LEDS_GPIO_DEFSTATE_OFF` for the brightness setting to work....

Ok, then that works as expected (as it does on my system, even before setting LEDS_GPIO_DEFSTATE_OFF). But if you set `echo 0 | sudo tee /sys/devices/platform/asustor_it87.*/hwmon/hwmon*/gpled1_blink` (gpled_blink, **not** gpled_bling_freq!) can...

Thanks! So just to make sure I understood you correctly: The latest code from my branch **plus** the `LEDS_GPIO_DEFSTATE_OFF` change I mentioned makes the green status LED work for you?...

> No, that is with the code from this branch as-is. I wanted to do a reboot first to see if that helped, and it did :) So, no change...

Hi @hlugt and @LPJon, you have tested the SATA5 and SATA6 LED support for Lockerstor AS6706T a while ago. As I don't own an AS6706T myself, I'm not sure if...