Dan Gould comments

Results 340 comments of


                                            Dan Gould

synchronize BIP 77 with code

I started pushing these changes to a [secondary branch](https://github.com/DanGould/bips/tree/pjv2-bak) so I don't interrupt the reviewers until we're ready for a review. FYI Note that Short IDs likely also need to...

synchronize BIP 77 with code

> ensure DHKEM is sufficiently documented in BIP 77 in an unambiguous spec, since it's a draft RFC now 77 links to the draft RFC. What more would make it...

`req-pj` behavior is described in the spec but not enforced in the code

IMO a URI containing both `param` and `req-param` needs to be handled by the `bip21`/`bitcoin_uri` crate as a single `param` parameter.

synchronize BIP 77 with code

Pushed changes to the [secondary branch](https://github.com/DanGould/bips/tree/pjv2-bak)

synchronize BIP 77 with code

#480 must be addressed for our implementation to be in sync with spec, which BIP 77 relies on, as must all existing Payjoin implementations

synchronize BIP 77 with code

Was it a mistake to use different `INFO` strings for HPKE? > All the algorithms also take an `info` parameter that can be used to influence the generation of keys...

synchronize BIP 77 with code

I'm going to mark DHKEM on the draft RFC as unambiguous unless you raise a further concern.

synchronize BIP 77 with code

Do you think it's also appropriate to have 2 separate info strings, one for a and one for b?

synchronize BIP 77 with code

I pushed to the bips repo. We're synced now, but missing the yet-to-be-defined-or-implemented ohttp relay payjoin directory relationship re: https://github.com/orgs/payjoin/discussions/486

synchronize BIP 77 with code

> UI/UX and privacy tradeoffs of relay and directory choices This is the only point that hasn't been addressed. I think the spririt of the issue is also to take...