Dan Albert

Results 430 comments of Dan Albert

This has slipped a few times because upstream won't allow us to assume LLD for Android, which makes it impossible to add any default flags that are only understood by...

> normally i'd trust rprichard's gut over mine in all things linker, but ... if that were true, why was chrome so keen on relocation packing? Chrome has an abnormal...

Big things like Chrome are the type of app that I expect to benefit from this. It's the smaller ones where it would maybe be a net negative. Or maybe...

The NDK at the time did not support SVE. r27 should (idr about r26). https://github.com/android/ndk-samples/issues/1011 for adding a sample.

I think he's worried about ASan breaking if we build libc.so with this flag. ASan relies on being able to replace the program's malloc (among other things), including the malloc...

I think you probably need to update https://github.com/android/ndk-samples/blob/ece52f26503987bbfd2ded8c73ffde05c457d035/hello-neon/app/src/main/cpp/helloneon-intrinsics.c#L18?

Actually it was the CMakeLists.txt that needed updating. Pushed the fix to your branch.

I don't understand what this has to do with the samples? Which sample are you talking about? Can reopen when that's clarified.

I'm not sure what you're asking me to do. What sample are you talking about?