Dan Albert

Results 430 comments of Dan Albert

The build failure doesn't happen locally :( I'll have to find some time to dig into this a bit, but the project structure in those samples is particularly ugly so...

The plan is for libclang to be in r28 (actually supported, on purpose, not just a thing we shipped accidentally like it was before). It'll be absent on Windows for...

To clarify: there is no android flavor of Clang. We built it, but it's the upstream source. The reason for the behavior difference is that it's a different version of...

We'll see what we can do, but we do give priority to regressions from the previous release over bugs that have been broken for a long time (if they've been...

I hadn't read closely enough before (evidently I really needed that vacation) and missed that this was ASan related. @kellermanrivero, have you tried HWASan? ASan isn't actually supported for Android...

> @DanAlbert my team is moving away from a really old NDK r18 into latest one so I guess maybe ASAN was the recommended option for R18. I will try...

Tentatively adding this for r27b so we remember to check, but due to the lack of upstream support for ASan, there may never be a fix for us to pick...

Maybe. If the bug is present but asymptomatic on arm64, hwasan should still be able to catch it. If it's in arm32-specific code though, yeah, hwasan won't help you :(

Yeah, confirmed that there's a mismatch between the header and the annotation in the map file that generates those stubs. I'll start working on figuring out which one of them...

Looks like a very old mistake of mine: https://r.android.com/278674. The map file change was autogenerated by https://r.android.com/251477 based on the contents of the older symbol list files. The headers, I...