Dan Albert

Results 430 comments of Dan Albert

> Why it is not set there (https://android.googlesource.com/platform/ndk/+/refs/heads/main/build/cmake/flags.cmake) by default? Because we should not be making policy decisions on your behalf. Any policies we set would change the behavior of...

(if any of that analysis is wrong, that's the best I can do without a repro case, and that's why we always ask for one, so upload one if you...

Okay, so it's a project that wasn't written for android, and for non-android targets it doesn't require anything newer than 2.8.12, but CMake (for good reasons) doesn't allow per-target minimum...

It's already on the todo list for r28, fwiw. I don't need additional convincing :) > What could have been done for better UX is: Check if cmake policy CMP0057...

> NDK 27 seems to be reaching vcpkg users in GH actions now. Then roll back to r26d until we can fix it. It's going to be a while still...

> ``` > cmake_policy(PUSH) > cmake_policy(SET CMP0057 NEW) > ... > cmake_policy(POP) > ``` Ah, I didn't realize we could push/pop those. We can do that instead. Thanks! The downside...

Neither can I. Use a docker image so github can't change your NDK out from underneath you?

Huh, we actually _do_ attempt to deal with this. There's a `cmake_minimum_required(VERSION 3.6.0)` right at the top of the toolchain file. I guess that doesn't do anything? My first attempt...

In fact, we don't even need to mess with policies. We just needed another `cmake_minimum_required(VERSION 3.6.0)` in `flags.cmake`. https://android-review.googlesource.com/c/platform/ndk/+/3211647 should fix this. The test I added now passes, anyway.

The upstream bug was closed with https://github.com/llvm/llvm-project/pull/121819, which is too new to be in r29.