CohenArthur comments

Results 260 comments of


                                            CohenArthur

Builtin macros

Edited to reflect which macros we really need to focus on for libcore 1.49

Privacy reporter cannot check resolved inferred types

Yep, all fixed now. Will add a testcase in a PR to close this out

Dataless enum variants can be matched without full path

@narpfel yes, I had reopened https://github.com/Rust-GCC/gccrs/issues/2144 as a follow up. We closed this issue because the original code would not compile, even though it should (with warnings)

`macro-issue1233.rs` is broken on big-endian systems

This should be fixed by #2156 as well

Type error in to_le implementation

Fixed by #2156

Design and handle first class types

Add following syntax? ```rust type Nothing; type Maybe[T] = | Nothing | T; ```

Design and handle first class types

Add following syntax? ```rust type Maybe[T] = | type Nothing | type Some(T); ```

private constants should not be accessed from outer namespace

Yeah, this is also true for static items: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=127506396739337c8e60b56c91427c69 Thanks for the report!

Unnecessary (?) ```TREE_SIDE_EFFECTS``` and ```TREE_READONLY``` usage

These two lines were needed when I added them at least, not sure if that has changed since. The abort calls were being optimized away otherwise.

Unnecessary (?) ```TREE_SIDE_EFFECTS``` and ```TREE_READONLY``` usage

I think fixing this issue will be pretty simple - we can just remove those two lines and run the testsuite, which should fail if those lines where necessary. I've...