Unnecessary (?) ```TREE_SIDE_EFFECTS``` and ```TREE_READONLY``` usage

Open powerboat9 opened this issue 2 years ago • 2 comments

https://github.com/Rust-GCC/gccrs/blob/cfc51d46fcdb70bde84f030557c96866f3b18e23/gcc/rust/rust-gcc.cc#L1491-L1493

Jul 02 '23 17:07 powerboat9

Worth double checking this, we had issues with other intrinsics getting optimized away when we compile with all the torture options.

Jul 02 '23 22:07 philberty

These two lines were needed when I added them at least, not sure if that has changed since. The abort calls were being optimized away otherwise.

Jul 07 '23 12:07 CohenArthur

I think fixing this issue will be pretty simple - we can just remove those two lines and run the testsuite, which should fail if those lines where necessary. I've marked the issue as good-first-pr

Apr 15 '24 11:04 CohenArthur